{KeyVault} Support more long-running operations #14890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yungezz
reviewed
Aug 24, 2020
|
|
||
|
|
||
| def recover_keyvault(cmd, client, vault_name, resource_group_name, location): | ||
| def recover_keyvault(cmd, client, vault_name, resource_group_name, location, no_wait=False): |
Member
There was a problem hiding this comment.
will this be a breaking change to user if no_wait default false?
Contributor
Author
There was a problem hiding this comment.
will this be a breaking change to user if no_wait default false?
@yungezz No, it's not a breaking change. The previous behavior is synchronous as well.
Member
|
Do they all have |
Contributor
Author
@qwordy Yes, all of these commands have
|
qwordy
approved these changes
Aug 25, 2020
Member
|
hi @fengzhou-msft could you pls help to review? thanks |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
fengzhou-msft
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more long-running operations:
az keyvault recoveraz keyvault network-rule addaz keyvault network-rule removeaz keyvault set-policyaz keyvault delete-policyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.